This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: On resolving the MIPS gas branch reloc issue
- From: Nick Clifton <nickc at redhat dot com>
- To: ica2_ts at csv dot ica dot uni-stuttgart dot de
- Cc: echristo at redhat dot com, binutils at sources dot redhat dot com
- Date: 27 Feb 2003 14:36:39 +0000
- Subject: Re: On resolving the MIPS gas branch reloc issue
- References: <20030225092644.GE25303@rembrandt.csv.ica.uni-stuttgart.de><1046232750.2735.38.camel@ghostwheel.ges.redhat.com><20030227001413.GY31111@bubble.sa.bigpond.net.au><1046317246.5258.8.camel@ghostwheel.ges.redhat.com>
Hi Thiemo,
> > The changes might be in global files, but they're MIPS specific,
> > aren't they? I think that gives you the right and responsibility to
> > OK the patch.
> The changes might be in global files, but they're MIPS specific,
> aren't they? I think that gives you the right and responsibility to
> OK the patch.
Correct - even though reloc.c is a global file, the change is MIPS
specific so Eric can approve it.
Anyway...
> 2003-02-26 Thiemo Seufer <seufer at csv dot ica dot uni-stuttgart dot de>
>
> /bfd/ChangeLog
> * elf32-mips.c (elf_mips_howto_table_rel): Change definition of
> R_MIPS_PC16 to rightshift 2.
> (elf_reloc_map mips_reloc_map): Map to rightshifted BFD reloc.
> (bfd_elf32_bfd_reloc_type_lookup): Support
> BFD_RELOC_MIPSEMB_16_PCREL_S2.
> * elf64-mips.c (mips_elf64_howto_table_rel): Change definition of
> R_MIPS_PC16 to rightshift 2.
> (mips_elf64_howto_table_rela): Likewise.
> (mips_reloc_map): Map to rightshifted BFD reloc.
> * elfn32-mips.c: The same as in elf64-mips.c.
> * elfxx-mips.c (mips_elf_got_for_ibfd): Typo in comment.
> (mips_elf_calculate_relocation): Handle rightshifted addends for
> R_MIPS_PC16.
> * reloc.c (BFD_RELOC_MIPSEMB_16_PCREL_S2): New BFD relocation for
> MIPS Embedded PIC. Remove superfluous empty COMMENT.
> * libbfd.h: Regenerate.
> * bfd-in2.h: Regenerate.
>
> /gas/ChangeLog
> * config/tc-mips.c (append_insn): Add handling of
> BFD_RELOC_MIPSEMB_16_PCREL_S2. Avoid emitting unneeded
> BFD_RELOC_16_PCREL_S2 relocs and add earlier warnings about
> misaligned address and reange overflow.
> (macro_build): Add handling of BFD_RELOC_MIPSEMB_16_PCREL_S2. Add
> earlier warnings about misaligned address and reange overflow.
> (mips_ip): Add handling of BFD_RELOC_MIPSEMB_16_PCREL_S2.
> (md_apply_fix): Likewise. Fix warning output.
> (tc_gen_reloc): Add handling of BFD_RELOC_MIPSEMB_16_PCREL_S2.
> Allow BFD_RELOC_16_PCREL_S2 for all ABIs.
> (md_convert_frag): Add handling of BFD_RELOC_MIPSEMB_16_PCREL_S2.
>
> /tas/testsuite/ChangeLog
> * gas/mips/bge.d: Reactivate external branch tests.
> * gas/mips/bge.s: Likewise.
> * gas/mips/bgeu.d: Likewise.
> * gas/mips/bgeu.s: Likewise.
> * gas/mips/blt.d: Likewise.
> * gas/mips/blt.s: Likewise.
> * gas/mips/bltu.d: Likewise.
> * gas/mips/bltu.s: Likewise.
> * gas/mips/branch-misc-2.d: New File.
> * gas/mips/branch-misc-2.l: Remove.
> * gas/mips/mips.exp: Adjust branch-misc-2 test.
Approved (global and mips specific changes) - please apply.
Cheers
Nick