This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Cyrix EMMI patch


On Tue, Dec 10, 2002 at 01:15:01PM +0100, Petr Sebor wrote:
> I'd like to contribute a support for the Cyrix MII extended multimedia 
> instructions
> to the binutils package. Please let me know what you think...

Hi Petr,
  There are a number of technical problem with your patch.  Firstly,
"pmulhrw" is already in i386_optab, so you need to add the new Cyrix
entry immediately adjacent to the existing one.  This leads me to
believe that you have never run "as" with your patch applied..
Secondly, the Cyrix opcodes duplicate existing opcodes.  For example,
0x0f51 is "paddsiw" on Cyrix and "sqrtps" for Intel SSE.  You need to
add some code to opcodes/i386-dis.c to select Cyrix disassembly.  You
should also submit a testsuite addition to exercise the new Cyrix
support.

Finally, you'll need to have a current copyright assignment/disclaimer
on file with the FSF.  I don't have a means of checking whether this
is already the case.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]