This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mips: branches to external labels are broken


On Nov 26, 2002, Alexandre Oliva <aoliva@redhat.com> wrote:

> On Nov 26, 2002, cgd@broadcom.com wrote:
>> At Tue, 26 Nov 2002 03:12:03 +0000 (UTC), "Alexandre Oliva" wrote:
>>> No regressions on the mips-elf testsuite.  Ok to install?

>> hmm, the ld testsuite still works?

> Erhm...  Nope.  Somehow I had the same failure in my base test
> results.  I probably messed something up.

e.g., reverting the assembler patch but not the bfd patch before
running the baseline tests.  Doh

I've just reverted all of my patches, ran the testsuite (got 2
failures in the ld testsuite, none elsewhere), installed the two
formerly-proposed patches in addition to the one below, rebuilt and
reran the tests, getting the same results (only difference was that
the linker had one less passing test, which was expected since I
removed one test).

Ok to install this one along with the others?

Index: ld/testsuite/ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* ld-mips-elf/mips-elf.exp: Remove branch-misc-2 test.
	* ld-mips-elf/branch-misc-2.d: Removed.

Index: ld/testsuite/ld-mips-elf/branch-misc-2.d
===================================================================
RCS file: ld/testsuite/ld-mips-elf/branch-misc-2.d
diff -N ld/testsuite/ld-mips-elf/branch-misc-2.d
--- ld/testsuite/ld-mips-elf/branch-misc-2.d 3 Oct 2002 23:56:24 -0000 1.2
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,30 +0,0 @@
-#name: MIPS branch-misc-2
-#source: ../../../gas/testsuite/gas/mips/branch-misc-2.s
-#objdump: --prefix-addresses -tdr --show-raw-insn
-#ld: -Ttext 0x500000 -e 0x500000 -N
-
-.*:     file format elf.*mips.*
-
-#...
-
-Disassembly of section \.text:
-	\.\.\.
-	\.\.\.
-	\.\.\.
-0+50003c <[^>]*> 0411fff0 	bal	0+500000 <[^>]*>
-0+500040 <[^>]*> 00000000 	nop
-0+500044 <[^>]*> 0411fff3 	bal	0+500014 <[^>]*>
-0+500048 <[^>]*> 00000000 	nop
-0+50004c <[^>]*> 0411fff6 	bal	0+500028 <[^>]*>
-0+500050 <[^>]*> 00000000 	nop
-0+500054 <[^>]*> 0411000a 	bal	0+500080 <[^>]*>
-0+500058 <[^>]*> 00000000 	nop
-0+50005c <[^>]*> 0411000d 	bal	0+500094 <[^>]*>
-0+500060 <[^>]*> 00000000 	nop
-0+500064 <[^>]*> 04110010 	bal	0+5000a8 <[^>]*>
-0+500068 <[^>]*> 00000000 	nop
-	\.\.\.
-	\.\.\.
-	\.\.\.
-	\.\.\.
-#pass
Index: ld/testsuite/ld-mips-elf/mips-elf.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-mips-elf/mips-elf.exp,v
retrieving revision 1.6
diff -u -p -r1.6 mips-elf.exp
--- ld/testsuite/ld-mips-elf/mips-elf.exp 3 Oct 2002 23:56:24 -0000 1.6
+++ ld/testsuite/ld-mips-elf/mips-elf.exp 26 Nov 2002 18:35:10 -0000
@@ -29,7 +29,6 @@ if { [istarget mips*-*-*] } then {
 
 	# MIPS branch offset final link checking.
 	run_dump_test "branch-misc-1"
-	run_dump_test "branch-misc-2"
     }
 
     if { $embedded_elf } {
-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]