This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add Toshiba TX49 support


At 19 Nov 2002 12:20:22 -0800, Eric Christopher wrote:
> This looks weird. Should probably pick one :) and leave out the
> underscore separating them.
> 
>         case bfd_mach_mips4400:
>         case bfd_mach_mips4600:
>         case bfd_mach_mips4650:
> +       case bfd_mach_mips_tx49:
>         case bfd_mach_mips8000:
>         case bfd_mach_mips10000:
>         case bfd_mach_mips12000:

Compare with bfd_mach_mips_sb1.  8-)

If it were me, I'd say that this is The Right Way, i.e.:

	bfd_mach_<arch>_<cpu>

Where <arch> is, uh... mips! and <cpu> is a friendly combination of
letters and digits which identifies the CPU vendor and CPU number in
question.

Of course, being the person who added SB-1 support, i'm inclined to
think that what I did was the right thing.  And hey, _somebody_
approved it (don't recall who, at this point 8-).



chris


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]