This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Toplevel patch: Autogenerate Makefile targets 2 (*-target-*)
- From: DJ Delorie <dj at redhat dot com>
- To: neroden at twcny dot rr dot com
- Cc: gcc-patches at gcc dot gnu dot org, binutils at sources dot redhat dot com, gdb-patches at sources dot redhat dot com
- Date: Wed, 13 Nov 2002 16:53:40 -0500
- Subject: Re: Toplevel patch: Autogenerate Makefile targets 2 (*-target-*)
- References: <20021113195200.GA28331@doctormoo>
> * Makefile.tpl: Autogenerate *-target-* targets.
> * Makefile.in: Regenerate.
> - @dir=`echo $@ | sed -e 's/configure-target-//'`; \
> + dir=[+module+] ; \
You dropped the '@' here. The '@' is a make thing, not part of the
scriptlet.
> -$(ALL_TARGET_MODULES):
> - @dir=`echo $@ | sed -e 's/all-target-//'`; \
> - if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +.PHONY: all-target-[+module+]
> +all-target-[+module+]:
> + dir=[+module+] ; \
'@' here.
> -$(CHECK_TARGET_MODULES):
> - @dir=`echo $@ | sed -e 's/check-target-//'`; \
> - if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +[+ IF no_check +][+ ELSE check +]
Is this the best place for this IF?
> +.PHONY: check-target-[+module+]
> +check-target-[+module+]:
> + dir=[+module+] ; \
'@' here.
> -$(INSTALL_TARGET_MODULES): installdirs
> - @dir=`echo $@ | sed -e 's/install-target-//'`; \
> - if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +[+ ENDIF no_check +]
This endif looks out of place.
> +[+ IF no_install +][+ ELSE install +]\
> +.PHONY: install-target-[+module+]
> +install-target-[+module+]: installdirs
> + dir=[+module+] ; \
'@' here.