This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [Patch] sh/sh64: Fix gotplt assertion failure
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Daniel Jacobowitz <drow at mvista dot com>
- Cc: binutils at sources dot redhat dot com, <stephen dot clarke at superh dot com>
- Date: Sun, 29 Sep 2002 21:38:22 -0400 (EDT)
- Subject: Re: [Patch] sh/sh64: Fix gotplt assertion failure
On Sun, 29 Sep 2002, Daniel Jacobowitz wrote:
> Nag hat: Could an SH maintainer please comment on this patch?
Thanks for the reminder. I thought Steven Clarke had a
maintainer colleague so I didn't look closer at the time. I bet
there are other patches left behind from him and others...
> > 2002-09-16 Stephen Clarke <stephen.clarke@superh.com>
> >
> > * elf32-sh.c (elf_sh_link_hash_entry): Add gotplt_refcount.
> > (sh_elf_link_hash_newfunc): Initialize it.
> > (allocate_dynrelocs): Transfer gotplt refs from plt.refcount
> > to got.refcount for symbols that are forced local or when
> > we have direct got refs.
> > (sh_elf_gc_sweep_hook): Adjust gotplt_refcount. Use it
> > to correctly adjust got.refcount and plt.refcount.
> > (sh_elf_copy_indirect_symbol): Copy gotplt_refcount across.
> > (sh_elf_check_relocs): Increment gotplt_refcount.
> >
> > ld/testsuite:
> >
> > 2002-09-16 Stephen Clarke <stephen.clarke@superh.com>
> >
> > * ld-sh/sh64/gotplt.d, ld-sh/sh64/gotplt.map,
> > ld-sh/sh64/gotplt.s: New test.
Looks ok to me (meaning nothing jumped out at me).
And there's a test-case! ;-)
brgds, H-P