This is the mail archive of the
mailing list for the binutils project.
write.c (subsegs_finish): Don't specially align last subseg.
- From: Doug Evans <dje at transmeta dot com>
- To: amodra at bigpond dot net dot au
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 6 Aug 2002 14:47:12 -0700
- Subject: write.c (subsegs_finish): Don't specially align last subseg.
Why was this code removed?
Not saying it shouldn't have been, just asking.
Has the "proper nop-filling" been achieved via other means?
Was the "proper nop-filling" the wrong thing to do?
[I scanned the subject lines of list traffic for May
but didn't see anything that stood out as relating to this.]
2002-05-13 Alan Modra <firstname.lastname@example.org>
* write.c (subsegs_finish): Don't specially align last subseg.
RCS file: /cvs/src/src/gas/write.c,v
retrieving revision 1.54
retrieving revision 1.55
diff -c -p -r1.54 -r1.55
*** write.c 1 May 2002 00:33:09 -0000 1.54
--- write.c 13 May 2002 01:23:51 -0000 1.55
*************** subsegs_finish ()
*** 1441,1452 ****
if we are generating a listing. */
alignment = had_errors () ? 0 : SUB_SEGMENT_ALIGN (now_seg);
- /* The last subsegment gets an aligment corresponding to the
- alignment of the section. This allows proper nop-filling
- at the end of code-bearing sections. */
- if (!frchainP->frch_next || frchainP->frch_next->frch_seg != now_seg)
- alignment = get_recorded_alignment (now_seg);
if (subseg_text_p (now_seg))
frag_align_code (alignment, 0);
--- 1441,1446 ----