This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Include libiberty.h in files that use htab_create()


> Cc: binutils@sources.redhat.com
> From: Nick Clifton <nickc@redhat.com>
> Date: 07 Jun 2002 11:43:56 +0100
> User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1
> 
> Hi Geoff,
> 
> > this is incompatible with the patch I just posted.  Could you look at
> > them both and work out which is correct?
> 
> Upon further searching I uncovered this patch:
> 
>   http://sources.redhat.com/ml/binutils/2002-06/msg00158.html
> 
>   2002-06-06  Geoffrey Keating  <geoffk@redhat.com>
> 
> 	* merge.c (merge_strings): Use htab_create_alloc with calloc, not
> 	htab_alloc.
> 	* elf-strtab.c (_bfd_elf_strtab_finalize): Likewise.
> 
> Is this the one you mean ?  If so why do you say that it is
> incompatible ?  I tried applying it and the BFD library appears to
> build just fine either with the binutils version of hashtab.h or the
> gcc version of it.

It's the designs that are incompatible.  One patch implies that the
correct thing to do is to use xcalloc; the other patch says that
xcalloc should never be used in BFD.

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]