This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH/RFA] Add sh5*-*-netbsd* and sh64*-*-netbsd* targets
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Jason R Thorpe <thorpej at wasabisystems dot com>
- Cc: <binutils at sources dot redhat dot com>
- Date: Mon, 3 Jun 2002 16:06:48 -0400 (EDT)
- Subject: Re: [PATCH/RFA] Add sh5*-*-netbsd* and sh64*-*-netbsd* targets
On Mon, 3 Jun 2002, Jason R Thorpe wrote:
> I'm particularly interested in a sanity-check on the change to tc-sh64.h.
> Without that change, I get a "redefined" warning for that macro (the
> original definition comes from tc-sh.h).
It seems that warning was overlooked when tc-sh64.h was merged
into the FSF binutils; MD_PCREL_FROM_SECTION was added to
tc-sh.h on 2001-09-30, and nobody noticed the warning since
tc-sh64.h was merged... Your change is obviously correct.
> Also, bfd/targets.c listed the existing sh64 vectors, but didn't actually
> put them in the targets array. I did the same thing with the new sh64_nbsd
> vectors. What's the right thing to do, here?
IIUC, that means it's currently there only if that's what BFD is
explicitly configured for. So if you use --enable-all-targets
it won't be listed in _bfd_target_vector[]. I think it should
be there, inside #ifdef BFD64. If everything builds with
--enable-all-targets, I'd count it as obvious.
> The new elf{32,64}-sh64{,l}-nbsd vectors are needed, because NetBSD
> does not use a leading underscore for user-visible symbols (this matches
> the elf32-sh-nbsd behavior).
>
> OK to commit?
Looks fine to me, except for some formatting issues 8-P with the
ChangeLog:
>
> bfd/
> * Makefile.am (BFD32_BACKENDS): Add elf32-sh64-nbsd.lo.
> (BFD32_BACKENDS_CFILES): Add elf32-sh64-nbsd.c.
> (BFD64_BACKENDS): Add elf64-sh64-nbsd.lo.
> (BFD64_BACKENDS_CFILES): Add elf64-sh64-nbsd.c.
> (elf32-sh64-nbsd.lo)
> (elf64-sh64-nbsd.lo): New rules.
Should be
(elf32-sh64-nbsd.lo, elf64-sh64-nbsd.lo): New rules.
or
(elf32-sh64-nbsd.lo): New rules.
(elf64-sh64-nbsd.lo): Ditto.
> * config.bfd (sh5le-*-netbsd*)
> (sh5-*-netbsd*)
> (sh64le-*-netbsd*)
> (sh64-*-netbsd*): New targets.
> * configure.in (sh5*): Set cpu_type to sh64 and endian to big.
> (sh5le*)
> (sh64le*): Set cpu_type to sh64 and endian to little.
> * Makefile.am (ALL_EMULATIONS): Add eshelf32_nbsd.o,
> eshlelf32_nbsd.o, eshelf64_nbsd.o, and eshlelf64_nbsd.o
> (eshelf32_nbsd.c)
> (eshelf64_nbsd.c)
> (eshlelf32_nbsd.c)
> (eshlelf64_nbsd.c): New rules.
> (sh5*-*-netbsd*)
> (sh64*-*-netbsd*): New targets.
> * configure.tgt (sh5le-*-netbsd*)
> (sh5-*-netbsd*)
> (sh64le-*-netbsd*)
> (sh64-*-netbsd*): New targets.
Ditto.
brgds, H-P