This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] objdump.c fix formatting.
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Elias Athanasopoulos <eathan at otenet dot gr>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 3 Jun 2002 14:18:04 +0930
- Subject: Re: [PATCH] objdump.c fix formatting.
- References: <20020603002219.A19064@neutrino.particles.org>
On Mon, Jun 03, 2002 at 12:22:19AM +0300, Elias Athanasopoulos wrote:
> Sorry for the previous careless posting. :-(
Your patch _introduces_ formatting errors, and there is no ChangeLog
entry.
Incidentanlly, I'm not aware of any place where the GNU coding
standard says not to use unnecessary braces. In fact, it stipulates
extra braces in a number of circumstances, eg. nested if, do while.
So IMHO we shouldn't be stripping out all unnecessary braces, although
I happen to agree they could be removed in the place you were patching.
I tend to like
if (some
|| multi
|| line
|| condition_particularly_if_the_last_line_is_long_and_)
{
one_statement_particularly_if_the_line_is_long;
}
simply because the braces visually separate the condition from the
body. Then again, I'm not going to get terribly upset if people
disagree with me on these style issues.
--
Alan Modra
IBM OzLabs - Linux Technology Centre