Re: [PATCH] pei386: make --enable-auto-import default

[Charles Wilson <cwilson at ece dot gatech dot edu>]

Nick Clifton wrote:

> 
>   Umm - my records do not show a binutils copyright assignment from
>   you.  Without such an assignment we really cannot accept patches to
>   binutils. :-(


fine, whatever.  damn, this is getting annoying (I'm in the middle of a 
move, and timely snail mail is tricky).  Does the assignment need to go 
to FSF?  If so, then you need to send me the 
/gd/gnuorg/request-assign.changes file from a GNU mirror (AFAICT, only 
folks with project-maintainer-level access to the GNU computers can 
access that file -- it ain't on the web).

 
>>-  link_info.pei386_auto_import = false;
>>+  link_info.pei386_auto_import = -1; /* 0=disable 1=enable */
>>
> 
>   I think that you should document what the -1 value means as well.


Okay, but I was just following the pattern established by stdcall_fixup...

 
>>-              einfo (_("Warning: resolving %s by linking to %s (auto-import)\n"),
>>+              if (link_info.pei386_auto_import == -1)
>>+              {
>>+                info_msg (_("Info: resolving %s by linking to %s (auto-import)\n"),
>>                      undef->root.string, buf);
>>+              }
>>
> 
>   You can drop the curly parentheses because there is only one statement
>   inside the block.


I know it's legal, but it's usually frowned on for maintainability 
reasons. If someone adds a second statement that SHOULD go inside the 
if-block, they must also add curly braces...and often forget to do so.

But, if GNU/binutils coding standards are such that single-statement 
if's don't need {}. then I'll do that.

--Chuck