This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cygwin ld import library issue fix (removing unused "_nm_" symbols)


Ralf Habacker wrote:

> 
> ... and accessing var0000 in client.cc 
> 
> Do you have really read the dll.h ?
> <snip>
> #define vars() \
> 	printf("v0000=%04d\n",var0000);\
> <snip>                      ^^^^^^^
> 
> the vars macro is called in client.cc !! 


</me hangs head in shame>
sorry, I missed that var() was a macro.  Thought it was a function.
</sorry>

You're right; you've demonstrated that your patch doesn't break 
backwards compatibility.  You've got my (tentative(*)) vote.

--Chuck

(*) tentative because I can't actually test it myself against HEAD, 
given the pre-existing problem with binutils HEAD on pe386.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]