PATCH: Fix visibility for MIPS (Re: 2 problems with ELF visibility)

["H . J . Lu" <hjl at lucon dot org>]

On Mon, Apr 22, 2002 at 12:06:57PM -0700, H . J . Lu wrote:
> There are 2 problems with ELF visibility:
> 
> 2. _bfd_elf_link_record_dynamic_symbol in elflink.c doesn't call
> elf_backend_hide_symbol. Instead, it sets ELF_LINK_FORCED_LOCAL directly.
> It doesn't work with MIPS. I got
> 
> mips-linux-gcc -O2 -pipe -D_GNU_SOURCE -D_REENTRANT -Wall -Wpointer-arith
> -Wstrict-prototypes -Wmissing-prototypes -Wno-char-subscripts -o test1 -static
> test1.o  ./.libs/libpopt.a
> /export/tools/lib/gcc-lib/mips-linux/2.96/../../../../mips-linux/bin/ld: not enough
> GOT space for local GOT entries
> /export/tools/lib/gcc-lib/mips-linux/2.96/../../../../mips-linux/bin/ld: BFD
> 2.12.90.0.5 20020421 internal error, aborting at
> /home/hjl/work/gnu/src/tools/tools/bfd/elfxx-mips.c line 5276 in
> _bfd_mips_elf_relocate_section
> 
> You have to use elf_backend_hide_symbol to turn a global symbol into local
> on MIPS. How should we fix it?
> 

I am enclosing a patch here. Any comments?


H.J.

Attachment: bfd-mips.patch
Description: Text document