This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[patch] bug in powerpc "dssall"
- From: matthew green <mrg at redhat dot com>
- To: binutils at sources dot redhat dot com
- Date: Wed, 17 Apr 2002 15:57:10 +1000
- Subject: [patch] bug in powerpc "dssall"
- Organisation: Red Hat, Asia-Pacific.
hi folks.
this patch fixes a bug in the altivec dssall instruction,
which takes no operands, but was expecting one.
OK to commit?
.mrg.
[gas/testsuite/ChangeLog]
* gas/ppc/altivec.d: Fix dssall test.
* gas/ppc/altivec.s: Likewise.
* gas/ppc/altivec_xcoff.d: Likewise.
* gas/ppc/altivec_xcoff.s: Likewise.
* gas/ppc/altivec_xcoff64.d: Likewise.
* gas/ppc/altivec_xcoff64.s: Likewise.
[opcodes/ChangeLog]
* ppc-opc.c (powerpc_opcode): Fix dssall operand list.
Index: gas/testsuite/gas/ppc/altivec.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/ppc/altivec.d,v
retrieving revision 1.1
diff -p -r1.1 altivec.d
*** gas/testsuite/gas/ppc/altivec.d 17 Oct 2001 13:13:15 -0000 1.1
--- gas/testsuite/gas/ppc/altivec.d 17 Apr 2002 05:49:08 -0000
*************** Disassembly of section \.text:
*** 8,14 ****
00000000 <start>:
0: 7c 60 06 6c dss 3
! 4: 7e 40 06 6c dssall 2
8: 7c 25 22 ac dst r5,r4,1
c: 7e 08 3a ac dstt r8,r7,0
10: 7c 65 32 ec dstst r5,r6,3
--- 8,14 ----
00000000 <start>:
0: 7c 60 06 6c dss 3
! 4: 7e 00 06 6c dssall
8: 7c 25 22 ac dst r5,r4,1
c: 7e 08 3a ac dstt r8,r7,0
10: 7c 65 32 ec dstst r5,r6,3
Index: gas/testsuite/gas/ppc/altivec.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/ppc/altivec.s,v
retrieving revision 1.1
diff -p -r1.1 altivec.s
*** gas/testsuite/gas/ppc/altivec.s 17 Oct 2001 13:13:15 -0000 1.1
--- gas/testsuite/gas/ppc/altivec.s 17 Apr 2002 05:49:08 -0000
***************
*** 3,9 ****
.section ".text"
start:
dss 3
! dssall 2
dst 5,4,1
dstt 8,7,0
dstst 5,6,3
--- 3,9 ----
.section ".text"
start:
dss 3
! dssall
dst 5,4,1
dstt 8,7,0
dstst 5,6,3
Index: gas/testsuite/gas/ppc/altivec_xcoff.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/ppc/altivec_xcoff.d,v
retrieving revision 1.1
diff -p -r1.1 altivec_xcoff.d
*** gas/testsuite/gas/ppc/altivec_xcoff.d 14 Feb 2002 22:41:04 -0000 1.1
--- gas/testsuite/gas/ppc/altivec_xcoff.d 17 Apr 2002 05:49:08 -0000
*************** Disassembly of section .text:
*** 8,14 ****
0000000000000000 <.text>:
0: 7c 60 06 6c dss 3
! 4: 7e 40 06 6c dssall 2
8: 7c 25 22 ac dst r5,r4,1
c: 7e 08 3a ac dstt r8,r7,0
10: 7c 65 32 ec dstst r5,r6,3
--- 8,14 ----
0000000000000000 <.text>:
0: 7c 60 06 6c dss 3
! 4: 7e 00 06 6c dssall
8: 7c 25 22 ac dst r5,r4,1
c: 7e 08 3a ac dstt r8,r7,0
10: 7c 65 32 ec dstst r5,r6,3
Index: gas/testsuite/gas/ppc/altivec_xcoff.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/ppc/altivec_xcoff.s,v
retrieving revision 1.1
diff -p -r1.1 altivec_xcoff.s
*** gas/testsuite/gas/ppc/altivec_xcoff.s 14 Feb 2002 22:41:04 -0000 1.1
--- gas/testsuite/gas/ppc/altivec_xcoff.s 17 Apr 2002 05:49:08 -0000
*************** main:
*** 7,13 ****
.csect .text[PR]
.main:
dss 3
! dssall 2
dst 5,4,1
dstt 8,7,0
dstst 5,6,3
--- 7,13 ----
.csect .text[PR]
.main:
dss 3
! dssall
dst 5,4,1
dstt 8,7,0
dstst 5,6,3
Index: gas/testsuite/gas/ppc/altivec_xcoff64.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/ppc/altivec_xcoff64.d,v
retrieving revision 1.1
diff -p -r1.1 altivec_xcoff64.d
*** gas/testsuite/gas/ppc/altivec_xcoff64.d 14 Feb 2002 22:41:04 -0000 1.1
--- gas/testsuite/gas/ppc/altivec_xcoff64.d 17 Apr 2002 05:49:08 -0000
*************** Disassembly of section .text:
*** 8,14 ****
0000000000000000 <.text>:
0: 7c 60 06 6c dss 3
! 4: 7e 40 06 6c dssall 2
8: 7c 25 22 ac dst r5,r4,1
c: 7e 08 3a ac dstt r8,r7,0
10: 7c 65 32 ec dstst r5,r6,3
--- 8,14 ----
0000000000000000 <.text>:
0: 7c 60 06 6c dss 3
! 4: 7e 00 06 6c dssall
8: 7c 25 22 ac dst r5,r4,1
c: 7e 08 3a ac dstt r8,r7,0
10: 7c 65 32 ec dstst r5,r6,3
Index: gas/testsuite/gas/ppc/altivec_xcoff64.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/ppc/altivec_xcoff64.s,v
retrieving revision 1.1
diff -p -r1.1 altivec_xcoff64.s
*** gas/testsuite/gas/ppc/altivec_xcoff64.s 14 Feb 2002 22:41:04 -0000 1.1
--- gas/testsuite/gas/ppc/altivec_xcoff64.s 17 Apr 2002 05:49:08 -0000
*************** main:
*** 7,13 ****
.csect .text[PR]
.main:
dss 3
! dssall 2
dst 5,4,1
dstt 8,7,0
dstst 5,6,3
--- 7,13 ----
.csect .text[PR]
.main:
dss 3
! dssall
dst 5,4,1
dstt 8,7,0
dstst 5,6,3
Index: opcodes/ppc-opc.c
===================================================================
RCS file: /cvs/src/src/opcodes/ppc-opc.c,v
retrieving revision 1.31
diff -p -r1.31 ppc-opc.c
*** opcodes/ppc-opc.c 4 Apr 2002 14:05:44 -0000 1.31
--- opcodes/ppc-opc.c 17 Apr 2002 05:49:09 -0000
*************** const struct powerpc_opcode powerpc_opco
*** 3672,3678 ****
{ "rac", X(31,818), X_MASK, PWRCOM, { RT, RA, RB } },
{ "dss", XDSS(31,822,0), XDSS_MASK, PPCVEC, { STRM } },
! { "dssall", XDSS(31,822,1), XDSS_MASK, PPCVEC, { STRM } },
{ "srawi", XRC(31,824,0), X_MASK, PPCCOM, { RA, RS, SH } },
{ "srai", XRC(31,824,0), X_MASK, PWRCOM, { RA, RS, SH } },
--- 3672,3678 ----
{ "rac", X(31,818), X_MASK, PWRCOM, { RT, RA, RB } },
{ "dss", XDSS(31,822,0), XDSS_MASK, PPCVEC, { STRM } },
! { "dssall", XDSS(31,822,1), XDSS_MASK, PPCVEC, { 0 } },
{ "srawi", XRC(31,824,0), X_MASK, PPCCOM, { RA, RS, SH } },
{ "srai", XRC(31,824,0), X_MASK, PWRCOM, { RA, RS, SH } },