This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] windres bugs - Resubmit

From: "Eric Kohl" <ekohl at rz-online dot de>
To: "DJ Delorie" <dj at delorie dot com>, <nickc at cambridge dot redhat dot com>
Cc: <binutils at sources dot redhat dot com>
Date: Sat, 13 Apr 2002 15:31:11 +0200
Subject: Re: [PATCH] windres bugs - Resubmit
References: <02041219425102.00957@local> <m3u1qg7qof.fsf@north-pole.nickc.cambridge.redhat.com> <200204121757.g3CHvG329740@envy.delorie.com>


"DJ Delorie" <dj@delorie.com> wrote:


>
> > It would *really* help if you could provide a couple of test cases for
> > these two bugs.  See the file
binutils/testsuite/binutils-all/windres/README
> > for details of what is needed.
>
> I agree.  IMHO patches to windres that do not include a testcase that
> builds with MSVC should be rejected.  Only by comparing with MSVC can
> we guarantee compatibility.
>
> Note that the comparison files in the testsuite are generated *with*
> MSVC.
>

Okay. I'll write some testcases and resubmit a more complete patch later.

Eric

References:
- [PATCH] windres bugs - Resubmit
  - From: Eric Kohl
- Re: [PATCH] windres bugs - Resubmit
  - From: Nick Clifton
- Re: [PATCH] windres bugs - Resubmit
  - From: DJ Delorie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]