This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: gas symbols.c functions
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Ben Elliston <bje at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 22 Feb 2002 16:46:23 +1030
- Subject: Re: gas symbols.c functions
- References: <15477.45429.697604.464454@scooby.brisbane.redhat.com>
On Fri, Feb 22, 2002 at 01:48:21PM +1100, Ben Elliston wrote:
> These are all functions, yet are named as if they might be macros or
> enum constants (in violation of the GNU coding standard). Ideally,
> these functions should also be prefixed with `symbol', not `s'. If
> this was done, the patch would be *huge*. Comments?
Grin. I suppose you could rename the functions in symbols.c, and
then define macros like
#define S_IS_FUNCTION symbol_is_function
That should satisfy the standard without a huge patch.
Seriously, many of these functions are macros in old non-bfd
targets. And no, I don't advocate more macros.
Alan