This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] print additional mips elf 64 reloc type info in readelf
- From: Nick Clifton <nickc at cambridge dot redhat dot com>
- To: Timothy Daly <remote_bob at yahoo dot com>
- Cc: binutils at sources dot redhat dot com
- Date: 18 Feb 2002 08:47:31 +0000
- Subject: Re: [patch] print additional mips elf 64 reloc type info in readelf
- References: <20020218003222.79315.qmail@web10208.mail.yahoo.com>
Hi Timothy,
The patch is basically OK. Just a couple of minor points:
> + if (is_rela)
> + printf
> + (_(" Offset Info Type Type2 Type3 Symbol's Value Symbol's Name Addend\n"));
By default, readelf tries to limit its output width to 80 characters
(unless the --wide command line option has been given). It would be
good if you could reformat the information display to fit in with this
philosophy.
> + if (!is_32bit_elf) {
> + rtype2 = elf_mips_reloc_type (type2);
> + rtype3 = elf_mips_reloc_type (type3);
> + }
Formatting - opening brace on a line of its own.
Cheers
Nick