This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Demangling broken (was: Re: [PATCH] Demangler woes with current CVS and type names)


> Please go the other way.  This is an incompatible interface change -
>> > and you've seen the violence you did to GDB and LD testsuites with this
>> > patch by now, right?
> 
>> 
>> That's what this whole conversation has been about... have you read
>> the thread?
>> 
>> If by "the other way" you mean checking for leftover characters in the
>> mangled string, it won't work; see H-P's mail.  An identifier called 'i'
>> would be incorrectly demangled as 'int' but no characters are left over.
>> 
>> 
>> Sigh.  I'll revert the patch when I have time to patch and test, about an
>> hour or so from now.
>> 
> 
> 
> Can we add
> 
> /* V3 ABI demangling entry points, defined in cp-demangle.c. Also
>    demagle types. */
> extern char*
> cplus_demangle_v3_type PARAMS ((const char* mangled));
> 
> and only call cplus_demangle_v3_type from c++filt?


Yes.  I think that was also Daniel's point.  Certainly play with a new 
interface.  Just remember to preserve the semantics on the existing one.

enjoy,
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]