This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH v2, Re: gprof failed to compile

On Thu, Jan 31, 2002 at 03:19:38PM -0600, Tom Rix wrote:
> Daniel Jacobowitz wrote:
> 
> > On Thu, Jan 31, 2002 at 11:27:05AM -0600, Tom Rix wrote:
> > > I am getting a new build error for gprof on AIX.
> > >
> > > Looks like it is caused by not typedef-ing bool.
> > >
> > > >
> > > >         * gprof.h: Don't include ansidecl.h, do include bfd.h.
> > > >         (bool): Don't typedef.
> > >
> > > The included patch reverts the bool to typedef-ed to int.
> > >
> > > Ok to commit?
> >
> > No, not OK.  The whole point was that we may now typedef bool in
> > "bfd.h".
> >
> > Consider seeing what breaks if you typedef bool in bfd.h on the
> > non-<stdbool.h> code path?
> 
> Moved the typedef to bfd-in.h and gprof builds.
> Nothing breaks building wise.   Runtime should just work.

Fine by me, unless Alan objects.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]