This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] '0x' prefix on objdump addresses


Graydon Hoare <graydon@redhat.com> writes:

> $ objdump -d ne_locks.o
> 
>   [...]
>   15f:   8b 1f                   mov    (%edi),%ebx
>   161:   85 db                   test   %ebx,%ebx
> - 163:   74 2b                   je     190 <submit_lock+0x40>
> + 163:   74 2b                   je     0x190 <submit_lock+0x40>
>   165:   8d 74 26 00             lea    0x0(%esi,1),%esi
>   169:   8d bc 27 00 00 00 00    lea    0x0(%edi,1),%edi
>   [...]
> 
> It's a matter of consistency; all hex values in the disassembly _except_
> this case are already prefixed by "0x".  

The addresses on the left are in hex but are not prefixed by 0x.  The
190 is an address which will appear on the left in a few lines.  If we
add the 0x before 190, then I think we have add a 0x to the addresses
on the left as well.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]