This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Merging of various patches for d10v gas
- From: Nick Clifton <nickc at cambridge dot redhat dot com>
- To: Alan Matsuoka <alanm at cygnus dot com>
- Cc: binutils at sources dot redhat dot com
- Date: 18 Dec 2001 12:56:38 +0000
- Subject: Re: Merging of various patches for d10v gas
- References: <20011211125312.A17555@85689-b.mtwh.phub.net.cable.rogers.com>
Hi Alan,
> The following patches are from various fixes that have been
> floating around and have not been merged back into the head.
This patch appears to contain a lot of redundant and incorrect
changes.
For example:
> ***************
> *** 20,31 ****
> Boston, MA 02111-1307, USA. */
>
> #include <stdio.h>
> #include "as.h"
> - #include "safe-ctype.h"
> #include "subsegs.h"
> #include "opcode/d10v.h"
> --- 19,29 ----
> Boston, MA 02111-1307, USA. */
>
> #include <stdio.h>
> + #include <ctype.h>
> #include "as.h"
> #include "subsegs.h"
> #include "opcode/d10v.h"
This is wrong. "safe-ctype.h" should be used in preference to ctype.h
> *************** int Optimizing = 0;
> *** 42,48 ****
> && S_GET_VALUE ((X)->X_op_symbol) == AT_WORD_RIGHT_SHIFT)
> #define AT_WORD_RIGHT_SHIFT 2
>
> ! /* Fixups. */
> #define MAX_INSN_FIXUPS (5)
> struct d10v_fixup
> {
> --- 40,47 ----
> && S_GET_VALUE ((X)->X_op_symbol) == AT_WORD_RIGHT_SHIFT)
> #define AT_WORD_RIGHT_SHIFT 2
>
> !
> ! /* fixups */
> #define MAX_INSN_FIXUPS (5)
> struct d10v_fixup
> {
This is also wrong. It is breaking the conventions for comment
formatting.
Please could you resubmit this patch after removing all the redundant
or backwards changes and only including the relevant bug fixes and
improvements.
Cheers
Nick