This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Minor PA GAS testsuite fix
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: law at redhat dot com
- Cc: binutils at sources dot redhat dot com
- Date: Sat, 8 Dec 2001 10:18:43 +1030
- Subject: Re: Minor PA GAS testsuite fix
- References: <20011124102719.N6922@bubble.sa.bigpond.net.au> <2160.1007741663@porcupine.cygnus.com>
On Fri, Dec 07, 2001 at 09:14:23AM -0700, law@redhat.com wrote:
> > On Fri, Nov 23, 2001 at 09:20:25AM -0500, law@redhat.com wrote:
> > >
> > > The line separator test is expected to fail on PA platforms.
> > >
> > > * gas/hppa/parse/parse.exp: Expect failure on line separator bug.
> >
> > Huh?
> >
> > Running /src/binutils-current/gas/testsuite/gas/hppa/parse/parse.exp ...
> > PASS: line separator bug
> The problem here is that the test in the net tree was incorrectly changed
> (by moving around some whitespace). That change masked the underlying
> bug in gas. The line separator test still fails if it's returned to its
> original form:
>
> .WORD 0 !.IMPORT $bar$,DATA
>
>
> I'm restoring the test to its original form so that we don't falsely believe
> that the line separator actually works in a manner that is consistent with
> the HP assembler's behavior.
No, what you've done in removing the whitespace before the .import, is
turn it into a label. hppa defines LABELS_WITHOUT_COLONS. Please put
the test back as it was, and remove the xfail.
Alan