This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: i386 gas is broken
On Fri, Nov 16, 2001 at 09:18:18AM +1030, Alan Modra wrote:
> On Thu, Nov 15, 2001 at 09:15:53AM -0500, Daniel Jacobowitz wrote:
> > On Thu, Nov 15, 2001 at 06:18:01PM +1030, Alan Modra wrote:
> > >
> > > * elflink.h (elf_link_input_bfd): Complain about all relocs against
> > > local syms from discarded sections, not just the section sym.
> > >
> > > I'm building x86 binutils with this and the above at the moment..
> >
> > Would the matching change to elf_reloc_symbol_deleted_p make sense?
> > The same test is there.
>
> Yes, I think so. Please test and commit if it seems to work.
No failures, with or without the change. But given my track record
lately, is this safe?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
Index: bfd/elflink.h
===================================================================
RCS file: /cvs/src/src/bfd/elflink.h,v
retrieving revision 1.125
diff -u -r1.125 elflink.h
--- elflink.h 2001/11/15 09:31:25 1.125
+++ elflink.h 2001/11/16 02:02:03
@@ -7811,7 +7811,7 @@
else if (rcookie->locsyms)
{
/* It's not a relocation against a global symbol,
- but it could be a relocation against a section
+ but it could be a relocation against a local
symbol for a discarded section. */
asection *isec;
@@ -7820,7 +7820,6 @@
{
isec = section_from_elf_index (rcookie->abfd, isym.st_shndx);
if (isec != NULL
- && ELF_ST_TYPE (isym.st_info) == STT_SECTION
&& ! bfd_is_abs_section (isec)
&& bfd_is_abs_section (isec->output_section))
return true;