This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
'T3' in mips16-opc.c [w/PATCH]
- To: binutils at sources dot redhat dot com
- Subject: 'T3' in mips16-opc.c [w/PATCH]
- From: cgd at broadcom dot com
- Date: 17 Oct 2001 11:23:18 -0700
Doing a recent merge with current binutils sources, I noticed that
'T3' in mips16-opc.c is defined, but never used.
It was present in the initial import of the file, back in '99.
Is there any reason it's actually defined there? (Is this something
put in for the convenience of Cygnus merges, or something that
accidentally escaped from the Cygnus? If it's like that, well, i'm
occasionally for accomodation in the name of easier merges... but it's
been like 2.5 years... 8-)
If no reason for it to be there, any objections to the change below?
(I've been running it in a local src tree for a while, but will give
it the standard set of builds & binutils testsuite runs, just for my
own sanity, before I check it in... 8-)
chris
==
2001-10-17 Chris Demetriou <cgd@broadcom.com>
* mips16-opc.c (T3): Remove unused definition.
Index: mips16-opc.c
===================================================================
RCS file: /cvs/src/src/opcodes/mips16-opc.c,v
retrieving revision 1.4
diff -u -r1.4 mips16-opc.c
--- mips16-opc.c 2001/03/13 22:58:37 1.4
+++ mips16-opc.c 2001/10/17 17:56:18
@@ -60,8 +60,6 @@
#define I3 INSN_ISA3
-#define T3 INSN_3900
-
const struct mips_opcode mips16_opcodes[] =
{
{"nop", "", 0x6500, 0xffff, RD_Z, 0 }, /* move $0,$Z */