This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: src/bfd som.c

On Fri, Sep 28, 2001 at 09:35:46PM -0000, wrote:
> Log message:
> 	som_write_symbol_strings: Fix incorrect type of current_offset to match
> 	the function definition. Fixes a build failure on HPUX-11.00.

Thanks for fixing my breakage.  As I said..

: Caveats: Some of the core file handling code, and som.c, can only be
: compiled natively.  I'll be pleasantly surprised if I haven't temporarily
: broken something.

To be pedantic I'm committing the following, which accomplishes what I
was originally trying to fix in som_write_symbol_strings.

	* som.c (som_write_symbol_strings): Cast current_offset in
	bfd_seek call to match param type.

It'd be interesting to know if som.c now compiles with --enable-64-bit-bfd

Alan Modra

Index: bfd/som.c
RCS file: /cvs/src/src/bfd/som.c,v
retrieving revision 1.23
diff -u -p -r1.23 som.c
--- som.c	2001/09/28 21:35:45	1.23
+++ som.c	2001/09/29 05:58:09
@@ -3189,7 +3189,7 @@ som_write_symbol_strings (abfd, current_
   /* Seek to the start of the space strings in preparation for writing
      them out.  */
-  if (bfd_seek (abfd, current_offset, SEEK_SET) != 0)
+  if (bfd_seek (abfd, (file_ptr) current_offset, SEEK_SET) != 0)
     return false;
   if (compilation_unit)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]