This is the mail archive of the
mailing list for the binutils project.
Re: [RFA] [pei-386] prevent ld (auto-import) from generating broken code
DJ Delorie wrote:
> Why is this one needed? That's what the ATTRIBUTE_UNUSED is for...
> The rest of it looks OK to me. I assume you're done the usual
> build/test cycle, yes?
Yes. Well, I have rebuilt & and tested with those revised patches, but
it wasn't a full "clean" test; I didn't wipe out my build dir and start
over from scratch. I'll do that now.
>>@@ -931,6 +947,8 @@
>> struct bfd_hash_entry *h;
>> PTR string ATTRIBUTE_UNUSED;
>> if (pe_dll_extra_pe_debug)
Ah -- I think that's because Paul was using non-current-cvs sources when
he developed the original patch. (However, I have been, so *my* version
of the patch has both the ATTRIBUTE_UNUSED thing and the (void)string
thing). The PTR string ATTRIBUTE_UNUSED thing was added sometime after
the late July/early August round of testing on auto-import.
I'm removing the (void)string thing, and then I'll do a complete (clean)