This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Add bfd_sprintf_vma/bfd_fprintf_vma
- To: "H . J . Lu" <hjl at lucon dot org>
- Subject: Re: PATCH: Add bfd_sprintf_vma/bfd_fprintf_vma
- From: "Maciej W. Rozycki" <macro at ds2 dot pg dot gda dot pl>
- Date: Fri, 10 Aug 2001 10:11:20 +0200 (MET DST)
- cc: binutils at sourceware dot cygnus dot com
- Organization: Technical University of Gdansk
On Thu, 9 Aug 2001, H . J . Lu wrote:
> +void
> +bfd_sprintf_vma (abfd, buf, value)
> + bfd *abfd;
> + char *buf;
> + bfd_vma value;
> +{
> + if (bfd_get_flavour (abfd) == bfd_target_elf_flavour)
> + return bfd_elf_sprintf_vma (abfd, buf, value);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> + sprintf_vma (buf, value);
> +}
I don't think returning a value from a void function is the cleanest idea
ever. Otherwise, I'll check the changes when my time permits. Thanks.
--
+ Maciej W. Rozycki, Technical University of Gdansk, Poland +
+--------------------------------------------------------------+
+ e-mail: macro@ds2.pg.gda.pl, PGP key available +