This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Add bfd_sprintf_vma/bfd_fprintf_vma
- To: "H . J . Lu" <hjl at lucon dot org>
- Subject: Re: PATCH: Add bfd_sprintf_vma/bfd_fprintf_vma
- From: Doug Evans <dje at transmeta dot com>
- Date: Thu, 9 Aug 2001 09:26:58 -0700 (PDT)
- Cc: "Maciej W. Rozycki" <macro at ds2 dot pg dot gda dot pl>, binutils at sourceware dot cygnus dot com
- References: <20010808150631.A2336@lucon.org><20010809090341.A18066@lucon.org>
H . J . Lu writes:
> On Wed, Aug 08, 2001 at 03:06:31PM -0700, H . J . Lu wrote:
> >
> > Here is the first step to implement it. After it is checked in, I will
> > replace as many sprintf_vma/fprintf_vma with _sprintf_vma/bfd_fprintf_vma
> > as I can to fix it. Any comments?
> >
>
> I checked in the following patch. I am coverting sprintf_vma/fprintf_vma
> to _sprintf_vma/bfd_fprintf_vma.
>
>
> H.J.
> ----
> 2001-08-09 H.J. Lu <hjl@gnu.org>
>
> * bfd-in.h (bfd_sprintf_vma): New prototype.
> (bfd_fprintf_vma): Likewise.
> (bfd_elf_sprintf_vma): Likewise.
> (bfd_elf_fprintf_vma): Likewise.
> (bfd_printf_vma): New. Defined with bfd_fprintf_vma.
> * bfd-in2.h: Regenerated.
>
> * bfd.c (bfd_sprintf_vma): New. Defined.
> (bfd_fprintf_vma): Likewise.
>
> * elf.c (bfd_elf_sprintf_vma): New. Defined.
> (bfd_elf_fprintf_vma): Likewise.
I'm not sure I'd bubble bfd_elf_*printf_vma up to the top.
Why not leave them be internal implementation details
of bfd_*printf_vma?