This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: The x86 gas seems broken.
- To: "H . J . Lu" <hjl at lucon dot org>, Artur Frysiak <wiget at pld dot org dot pl>, binutils at sourceware dot cygnus dot com
- Subject: Re: The x86 gas seems broken.
- From: Alan Modra <amodra at bigpond dot net dot au>
- Date: Thu, 26 Jul 2001 13:08:38 +0930
- References: <20010725121800.C12346@free.buy.pl> <20010725095508.B12404@lucon.org> <20010725193357.E29439@free.buy.pl> <20010725110321.A13588@lucon.org> <20010726103600.F14307@bubble.sa.bigpond.net.au>
On Thu, Jul 26, 2001 at 10:36:00AM +0930, Alan Modra wrote:
> On Wed, Jul 25, 2001 at 11:03:21AM -0700, H . J . Lu wrote:
> > Assertion failure in write_contents at write.c line 1189.
> > Please report this bug.
> >
> > Any ideas?
>
> Almost certainly a bug I introduced. I'll take a look.
Yeah, it was.
gas/ChangeLog
* write.c (relax_segment <rs_space>): Account for fr_fix.
Index: gas/write.c
===================================================================
RCS file: /cvs/src/src/gas/write.c,v
retrieving revision 1.42
diff -u -p -r1.42 write.c
--- write.c 2001/07/23 13:03:39 1.42
+++ write.c 2001/07/26 03:36:46
@@ -2479,7 +2479,7 @@ relax_segment (segment_frag_root, segmen
fragP->fr_symbol = 0;
}
else
- growth = (was_address + amount
+ growth = (was_address + fragP->fr_fix + amount
- fragP->fr_next->fr_address);
}
break;