This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH for i386: --no-copy-relocs
On Sun, Jun 24, 2001 at 08:17:57PM -0700, H . J . Lu wrote:
> On Mon, Jun 25, 2001 at 12:14:43PM +0930, Alan Modra wrote:
> > Some tweaks to H.J.'s fix to stop those R_386_NONE relocs from sneaking
> > in again.
> >
> > bfd/ChangeLog
> > * elf32-i386.c (allocate_plt_and_got_and_discard_relocs): Discard
> > relocs without ELF_LINK_HASH_DEF_DYNAMIC set.
> > (elf_i386_relocate_section <R_386_32, R_386_PC32>): Remove
> > redundant bfd_link_hash_defined, bfd_link_hash_defweak test.
> >
>
> I am not very sure about removing the check for bfd_link_hash_defined
> and bfd_link_hash_defweak. I don't know if it will work with weak
> undefined.
Removing those checks won't change the undef weak behaviour. Thanks
for the alert though. undef_weak is broken.