This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH, POINTER] Let gas support mips64


Ian Lance Taylor wrote:
>Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de> writes:
>
>> 	(load_register): Change register width check to use USES_32BIT_REGS.
>> 	Fix handling of sign bit in 64bit constants.
>
>A small thing: you're changing a pair of shifts by 16 to a single
>shift by 32.  That will lead to warnings when compiled on a 32 bit
>processor.  That's why the shifts by 16 are there.

I do so and get no warning. :-) I assume You meant a compiler
without an integral 64bit type.

To circumvent such warnings, I switched back to 2 16bit shifts
and changed the patch accordingly.

>Also, note that
>gas normally use valueT and addressT rather than bfd_vma.  (I actually
>don't see any semantic change here at all, although I am probably
>missing something.)

The whole existing mips64 support in binutils requires bfd_vma.


Thiemo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]