This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] SHF_MERGE fixes
- To: Jakub Jelinek <jakub at redhat dot com>
- Subject: Re: [PATCH] SHF_MERGE fixes
- From: amodra at one dot net dot au
- Date: Sun, 29 Apr 2001 01:08:53 +0930
- Cc: binutils at sources dot redhat dot com
- References: <20010420173238.A852@sunsite.ms.mff.cuni.cz>
On Fri, Apr 20, 2001 at 05:32:38PM +0200, Jakub Jelinek wrote:
> Ok to commit?
Yes.
> + mask = ((bfd_vma)1 << align) - 1;
Formatting.
> + if (!eltalign || eltalign > mask)
I think this is bad style, and should be written as
if (eltalign == 0 || eltalign > mask)
simply because the code doesn't read as well in the first form.
For the same reason, I don't particularly like "if (!strcmp (...))",
and other uses of `!' on non-boolean values but have to concede that
this is fairly common idiom.
Alan