This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch for readelf testsuite


On Fri, Mar 30, 2001 at 11:10:20AM -0800, Chris G. Demetriou wrote:
> "H . J . Lu" <hjl@lucon.org> writes:
> > On Fri, Mar 30, 2001 at 10:09:58AM -0800, Chris G. Demetriou wrote:
> > > Was this run through the testsuite on any particular architectures?
> > 
> > Yes/No. Yes, I ran it on Linux/ia32. No, it just skipped Linux/ia32.
> > Here is a patch.
> 
> Heh.  That's almost funny.  8-)
> 
> 
> perhaps add '"*-*elf"' to the list of supported targets, and don't
> bother with specifically mentioning ELF later?
> 

How about this one?

Thanks.

H.J.
---
Index: binutils-all/readelf.exp
===================================================================
RCS file: /work/cvs/gnu/binutils/binutils/testsuite/binutils-all/readelf.exp,v
retrieving revision 1.1.1.5
diff -u -p -r1.1.1.5 readelf.exp
--- binutils-all/readelf.exp	2001/03/15 22:51:57	1.1.1.5
+++ binutils-all/readelf.exp	2001/03/30 19:23:18
@@ -218,11 +218,24 @@ proc readelf_test { options binary_file 
 # For now be paranoid and assume that if ELF is not mentioned
 # in the target string, then the target is not an ELF based port.
 
-if ![istarget "*-*elf"] then {
+if { ![istarget *-*-elf*] \
+     && ![istarget *-*-linux*] \
+     && ![istarget i?86-*-sysv4*] \
+     && ![istarget i?86-*-unixware] \
+     && ![istarget mips*-*-irix5*] \
+     && ![istarget mips*-*-irix6*] \
+     && ![istarget powerpc-*-sysv4*] \
+     && ![istarget sparc*-*-solaris2*] } {
     verbose "$READELF is only intended for ELF targets" 2
     return
 }
 
+if { [istarget *-*-linuxoldld*] \
+     || [istarget *-*-linuxaout*] } {
+    verbose "$READELF is only intended for ELF targets" 2
+    return
+}
+
 if ![is_remote host] {
     if {[which $READELF] == 0} then {
         perror "$READELF does not exist"
@@ -270,4 +283,4 @@ if [is_remote host] {
 # The xfail targets here do not default to DWARF2 format debug information
 # The symptom is that the output of 'readelf -wi' is empty.
 
-readelf_test -wi $tempfile readelf.wi {v850*-*-* cris-*-*}
+readelf_test -wi $tempfile readelf.wi {v850*-*-* cris-*-* *-*-linux*}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]