This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Patch for readelf (readelf -u dumps core)
- To: hjl at lucon dot org ("H . J . Lu")
- Subject: Re: Patch for readelf (readelf -u dumps core)
- From: cgd at sibyte dot com (Chris G. Demetriou)
- Date: 30 Mar 2001 10:09:58 -0800
- Cc: binutils at sources dot redhat dot com, nickc at redhat dot com
- References: <20010328144344.A22625@lucon.org> <200103282312.SAA01149@ives.lkg.dec.com> <20010328154833.A23617@lucon.org> <mailpost.985824467.31797@postal.sibyte.com>
hjl@lucon.org ("H . J . Lu") writes:
> 2001-03-28 H.J. Lu <hjl@gnu.org>
>
> * readelf.c (process_unwind): Only do unwind sections for
> IA64.
>
> Index: readelf.c
> ===================================================================
> RCS file: /work/cvs/gnu/binutils/binutils/readelf.c,v
> retrieving revision 1.52
> diff -u -p -r1.52 readelf.c
> --- readelf.c 2001/03/17 20:47:58 1.52
> +++ readelf.c 2001/03/28 23:41:46
> @@ -3411,6 +3411,12 @@ process_unwind (file)
> unsigned long i, addr_size;
> struct unw_aux_info aux;
>
> + if (elf_header.e_machine != EM_IA_64)
> + {
> + printf (_("\nThere are no unwind sections in this file.\n"));
> + return 1;
> + }
> +
> memset (& aux, 0, sizeof (aux));
>
> addr_size = is_32bit_elf ? 4 : 8;
Was this run through the testsuite on any particular architectures?
On mips-elf, using sources updated this morning, comparing against
sources updated about a week ago, there are new failures:
FAIL: readelf -h
FAIL: readelf -S
FAIL: readelf -s
FAIL: readelf -r
And all of them go like:
extra lines in readelf.out starting with "^There are no unwind sections in this file.$"
cgd