This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch for readelf (readelf -u dumps core)


hjl@lucon.org ("H . J . Lu") writes:
> 2001-03-28  H.J. Lu  <hjl@gnu.org>
> 
> 	* readelf.c (process_unwind): Only do unwind sections for
> 	IA64.
> 
> Index: readelf.c
> ===================================================================
> RCS file: /work/cvs/gnu/binutils/binutils/readelf.c,v
> retrieving revision 1.52
> diff -u -p -r1.52 readelf.c
> --- readelf.c	2001/03/17 20:47:58	1.52
> +++ readelf.c	2001/03/28 23:41:46
> @@ -3411,6 +3411,12 @@ process_unwind (file)
>    unsigned long i, addr_size;
>    struct unw_aux_info aux;
>  
> +  if (elf_header.e_machine != EM_IA_64)
> +    {
> +      printf (_("\nThere are no unwind sections in this file.\n"));
> +      return 1;
> +    }
> +
>    memset (& aux, 0, sizeof (aux));
>  
>    addr_size = is_32bit_elf ? 4 : 8;

Was this run through the testsuite on any particular architectures?

On mips-elf, using sources updated this morning, comparing against
sources updated about a week ago, there are new failures:

FAIL: readelf -h
FAIL: readelf -S
FAIL: readelf -s
FAIL: readelf -r

And all of them go like:

extra lines in readelf.out starting with "^There are no unwind sections in this file.$"



cgd


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]