This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [Patch] Fix section flags in dlltool
Hi Roger,
> Alas no copyright assignment, but the fix is both obvious and taken
> directly from the gas source code in binutils. Tested on i686-pc-cygwin
> and with LINK.EXE from MSVC 5.0 and 6.0.
This is a close one to call, since the patch is slightly more complex
than a typical "obvious" fix. I will aceept it this once, but in the
future, in situations like this, I would much prefer it if you just
reported the bug (and maybe include a simple test case to reproduce
it), and let us develop a patch ourselves. Of course if you are
willing to sign a copyright assignment, then I would be happy to
accept patches as well.
> + 2001-03-28 Roger Sayle <roger@metaphorics.com>
> +
> + * dlltool.c (make_one_lib_file): Fix section flags for
> + .text, .data and .bss in stub ds*.o files to match those
> + generated by gas.
Approved.
DJ - can you apply this please - I am swamped at the moment.
Cheers
Nick