This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: The COFF patch causes testsuit failure on COFF


Hi H.J, Hi Nick

> The patch
> 
> 2001-03-27  Nick Papadonis  <nick@coelacanth.com>
> 
>         * read.c (equals): (for COFF) default symbols to being local.
> 
> caused testsuite/gas/macros/test1.exp to fail on COFF. test1.s has

The patch below fixes this regression.

Unfortunately I have not yet been able to determine why the arm-coff
port did not show this regression.

Nick - please can you try this patch out with your m68k-coff toolchain
and let me know if it reintroduces the bug that your patch was trying
to fix.

Cheers
        Nick

Index: gas/read.c
===================================================================
RCS file: /cvs/src//src/gas/read.c,v
retrieving revision 1.35
diff -p -r1.35 read.c
*** read.c	2001/03/27 19:13:55	1.35
--- read.c	2001/03/28 02:25:13
*************** equals (sym_name, reassign)
*** 4866,4872 ****
  
  #ifdef OBJ_COFF
        /* "set" symbols are local unless otherwise specified.  */
!       SF_SET_LOCAL (symbolP);
  #endif /* OBJ_COFF */
  
        pseudo_set (symbolP);
--- 4866,4873 ----
  
  #ifdef OBJ_COFF
        /* "set" symbols are local unless otherwise specified.  */
!       if (! S_IS_EXTERNAL (symbolP))
! 	SF_SET_LOCAL (symbolP);
  #endif /* OBJ_COFF */
  
        pseudo_set (symbolP);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]