This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] change to MIPS 4650 instruction support


"Chris G. Demetriou" wrote:
> 
> Really, in the long run, I think OPCODE_IS_MEMBER should take one,
> maybe two masks:
> 
>         (1) ISA
>         (2) set of CPU-related extensions to enable
> 
> (plus the 'gp32' flag if that's _really_ necessary...)  adding random
> flags isn't the way to go, and adding essentially a cpu-specific flag
> to mips_set_options is definitely not.
> 
> If you're trying to support a new CPU type, it seems obvious how to do
> that without rewriting a bunch of code.
> 

Also not being in a position to approve or reject I agree.  I'm adding
new cpu types currently (and fixing up some for contribution) and it is
quite easy without rewriting.

Anyhow, my 2 cents.

-eric


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]