This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Fix Relocs for x86-64
- To: Andreas Jaeger <aj at suse dot de>
- Subject: Re: Fix Relocs for x86-64
- From: Bo Thorsen <bo at sonofthor dot dk>
- Date: Sun, 11 Mar 2001 08:49:43 +0100 (CET)
- Cc: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>,<binutils at sources dot redhat dot com>
On 10 Mar 2001, Andreas Jaeger wrote:
> Hans-Peter Nilsson <hans-peter.nilsson@axis.com> writes:
>
> > > From: Andreas Jaeger <aj@suse.de>
> > > Date: 07 Mar 2001 14:48:08 +0100
> >
> > > We didn't handle some relocations correctly for x86-64, I've committed
> > > the appended patch to both branches after testing on both branches.
> >
> > I see the same hunk of code in several targets, but rarely a
> > line indicating what situations the code reflects. If you
> > happen to know and have this in clear memory, how about adding a
> > descriptive comment line or two? See the DWARF comment. I'll
> > help with an example which should match here.
> >
> > /* When creating a shared library, we can have an
> > ordinary relocation for a symbol defined in a shared
> > library (perhaps the one we create). We then make
> > the relocation value zero, as it will be added into
> > the relocation addend in this shared library.
> > FIXME: Not sure this example covers the
> > h->elf_link_hash_flags test. */
>
> That description looks fine. What do others think? I'm in favour of
> including it for x86-64.
I agree.
Bo.
--
Bo Thorsen | Lahnsgade 31, st.
Free software developer | 5000 Odense C
SuSE Labs | Denmark