This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Fix relocation bug
- To: Bo Thorsen <bo at suse dot de>
- Subject: Re: Fix relocation bug
- From: Andreas Schwab <schwab at suse dot de>
- Date: 28 Feb 2001 11:23:46 +0100
- Cc: patches at x86-64 dot org, binutils at sources dot redhat dot com
- References: <Pine.LNX.4.21.0102281055030.12044-100000@Wotan.suse.de>
Bo Thorsen <bo@suse.de> writes:
|> This bugfix feels wrong, so I would like some feedback on why it is
|> necessary and perhaps a better way to fix it.
|>
|> The problem was that R_X86_64_PC32 relocations were calculated
|> wrong. Replacing the bfd_elf_generic_reloc with zeros in the howto table
|> solved it, but it is probably not correct to do this for all entries.
This looks wrong. Have you tried setting partial_inplace to false for all
entries? Since x86-64 uses RELA relocations, this should not be set, see
the comment in reloc.c:
. All relocations for all ELF USE_RELA targets should set this field
. to FALSE (values of TRUE should be looked on with suspicion).
Andreas.
--
Andreas Schwab "And now for something
SuSE Labs completely different."
Andreas.Schwab@suse.de
SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg