This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[checked in patch] MIPS: don't test ELF features on non-ELF targets.


Just checked this in as an obvious fix.

("svr4pic" is the variable that actually says "is this elf or not", at
least according to other code in mips.exp and looking at the set of
targets for which it's set.)


2001-02-17  Chris Demetriou  <cgd@broadcom.com>

        * gas/mips/mips.exp: Don't attempt the elf_e_flags family of
        tests if not ELF; they test ELF-specific features.

Index: gas/mips/mips.exp
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips.exp,v
retrieving revision 1.6
diff -c -r1.6 mips.exp
*** mips.exp	2000/12/03 22:10:02	1.6
--- mips.exp	2001/02/18 01:47:55
***************
*** 91,108 ****
      run_dump_test "mips32"
      run_dump_test "mips64"
  
-     # Make sure that -mcpu=FOO and -mFOO are equivalent.  Assemble a file
-     # containing 4650-specific instructions with -m4650 and -mcpu=4650,
-     # and verify that they're the same.  Specifically, we're checking
-     # that the EF_MIPS_MACH field is set, and that the 4650 'mul'
-     # instruction does get used.  In previous versions of GAS, 
-     # only -mcpu=4650 would set the EF_MIPS_MACH field; -m4650 wouldn't.
-     run_dump_test "elf_e_flags1"
-     run_dump_test "elf_e_flags2"
-     run_dump_test "elf_e_flags3"
-     run_dump_test "elf_e_flags4"
-     
      if $svr4pic {
  	run_dump_test "elf-rel"
  	if [istarget mips64*-*-*] { 
  	    run_dump_test "elf-rel2" 
--- 91,108 ----
      run_dump_test "mips32"
      run_dump_test "mips64"
  
      if $svr4pic {
+ 	# Make sure that -mcpu=FOO and -mFOO are equivalent.  Assemble a file
+ 	# containing 4650-specific instructions with -m4650 and -mcpu=4650,
+ 	# and verify that they're the same.  Specifically, we're checking
+ 	# that the EF_MIPS_MACH field is set, and that the 4650 'mul'
+ 	# instruction does get used.  In previous versions of GAS, 
+ 	# only -mcpu=4650 would set the EF_MIPS_MACH field; -m4650 wouldn't.
+ 	run_dump_test "elf_e_flags1"
+ 	run_dump_test "elf_e_flags2"
+ 	run_dump_test "elf_e_flags3"
+ 	run_dump_test "elf_e_flags4"
+     
  	run_dump_test "elf-rel"
  	if [istarget mips64*-*-*] { 
  	    run_dump_test "elf-rel2" 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]