This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: ecoff.c bit rot?
- To: pb at futuretv dot com
- Subject: Re: ecoff.c bit rot?
- From: Nick Clifton <nickc at redhat dot com>
- Date: Wed, 14 Feb 2001 11:35:40 -0800
- CC: binutils at sources dot redhat dot com
Hi Phil,
: I noticed these warnings while compiling:
:
: /labs/src/cygnus/binutils-2.11-branch/src/bfd/ecoff.c:80: warning: initialization makes integer from pointer without a cast
: /labs/src/cygnus/binutils-2.11-branch/src/bfd/ecoff.c:90: warning: initialization from incompatible pointer type
: /labs/src/cygnus/binutils-2.11-branch/src/bfd/ecoff.c:91: warning: missing initializer
: /labs/src/cygnus/binutils-2.11-branch/src/bfd/ecoff.c:91: warning: (near initialization for `bfd_debug_section.symbol_ptr_ptr')
Bit rot indeed. I have appleid the patch below to fix this.
Cheers
Nick
2001-02-14 Nick Clifton <nickc@redhat.com>
* ecoff.c (bfd_debug_section): Update to initialise new fields in
asection structure.
Index: ecoff.c
===================================================================
RCS file: /cvs/src//src/bfd/ecoff.c,v
retrieving revision 1.5
diff -p -r1.5 ecoff.c
*** ecoff.c 2000/11/22 00:56:55 1.5
--- ecoff.c 2001/02/14 19:34:23
***************
*** 1,5 ****
/* Generic ECOFF (Extended-COFF) routines.
! Copyright 1990, 91, 92, 93, 94, 95, 96, 97, 98, 99, 2000
Free Software Foundation, Inc.
Original version by Per Bothner.
Full support added by Ian Lance Taylor, ian@cygnus.com.
--- 1,5 ----
/* Generic ECOFF (Extended-COFF) routines.
! Copyright 1990, 91, 92, 93, 94, 95, 96, 97, 98, 99, 2000, 2001
Free Software Foundation, Inc.
Original version by Per Bothner.
Full support added by Ian Lance Taylor, ian@cygnus.com.
*************** static unsigned int ecoff_armap_hash PAR
*** 74,93 ****
static asection bfd_debug_section =
{
! /* name, index, next, flags, set_vma, reloc_done, linker_mark, gc_mark */
! "*DEBUG*", 0, 0, 0, 0, 0, 0, 0,
! /* vma, lma, _cooked_size, _raw_size, output_offset, output_section, */
! 0, 0, 0, 0, 0, NULL,
! /* alig, reloc..., orel..., reloc_count, filepos, rel_..., line_... */
! 0, 0, 0, 0, 0, 0, 0,
! /* userdata, contents, lineno, lineno_count */
! 0, 0, 0, 0,
! /* comdat_info, moving_line_filepos, target_index, used_by_bfd, */
! NULL, 0, 0, 0,
! /* cons, owner, symbol */
! 0, 0, (struct symbol_cache_entry *) NULL,
! /* symbol_ptr_ptr, link_order_head, ..._tail */
! (struct symbol_cache_entry **) NULL, NULL, NULL
};
/* Create an ECOFF object. */
--- 74,99 ----
static asection bfd_debug_section =
{
! /* name, id, index, next, flags, user_set_vma, reloc_done, */
! "*DEBUG*", 0, 0, 0, 0, 0, 0,
! /* linker_mark, gc_mark, segment_mark, vma, lma, _cooked_size, */
! 0, 0, 0, 0, 0, 0,
! /* _raw_size, output_offset, output_section, alignment_power, */
! 0, 0, NULL, 0,
! /* relocation, orelocation, reloc_count, filepos, rel_filepos, */
! 0, 0, 0, 0, 0,
! /* line_filepos, userdata, contents, lineno, lineno_count, */
! 0, NULL, NULL, NULL, 0,
! /* comdat, kept_section, moving_line_filepos, target_index, */
! NULL, NULL, 0, 0,
! /* used_by_bfd, constructor_chain, owner, */
! NULL, NULL, NULL,
! /* symbol, */
! (struct symbol_cache_entry *) NULL,
! /* symbol_ptr_ptr, */
! (struct symbol_cache_entry **) NULL,
! /* link_order_head, link_order_tail */
! NULL, NULL
};
/* Create an ECOFF object. */