This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] PIC support for X86-64
Bo Thorsen <bo@suse.de> writes:
> This patch adds PIC support to the X86-64. It is not much tested since
> this is not yet possible. It can create and link PIC code and that will
> have to do until glibc gets PIC support so we can start loading it.
>
> There are a few FIXME's in the code and I would love to have someone going
> over the patch and commenting on it.
>
> This is the ChangeLog entry:
>
> 2001-01-22 Bo Thorsen <bo@suse.de>
>
> * elf64-x86-64.c: Added PIC support for X86-64.
> (elf64_x86_64_link_hash_newfunc): Function added.
> (elf64_x86_64_link_hash_table_create): Likewise.
> (elf64_x86_64_check_relocs): Likewise.
> (elf64_x86_64_gc_mark_hook): Likewise.
> (elf64_x86_64_gc_sweep_hook): Likewise.
> (elf64_x86_64_adjust_dynamic_symbol): Likewise.
> (elf64_x86_64_size_dynamic_sections): Likewise.
> (elf64_x86_64_discard_copies): Likewise.
> (elf64_x86_64_finish_dynamic_symbol): Likewise.
> (elf64_x86_64_finish_dynamic_sections): Likewise.
> (elf64_x86_64_relocate_section): Add relocation of PIC sections.
>
> The patch is gzipped and attached because of it's size.
>
> Can this be commited?
[...]
> +static struct bfd_hash_entry *elf64_x86_64_link_hash_newfunc
> + PARAMS ((struct bfd_hash_entry *, struct bfd_hash_table *, const char *));
> +static boolean elf64_x86_64_adjust_dynamic_symbol
> + PARAMS((struct bfd_link_info *, struct elf_link_hash_entry *));
Add one space before the bracked as you've done everywhere else.
> +/* The name of the dynamic interpreter. This is put in the .interp
> + section. */
> +
> +#define ELF_DYNAMIC_INTERPRETER "/lib/libd64.so"
Please change this to /lib/ld64.so.1.
Thanks a lot. IMO this could be added to the binutils archive and
I'll do so tonight (with those two changes) if nobody finds serious
problems or objects.
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj