This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: new tests


Hi Phil,

: The new gas test `arm/msr-bad' fails at the moment; I think this is
: a relatively recent piece of breakage, though I haven't investigated
: yet. 

Well this is possibly a matter of interpretation.  The supposedly bad
instruction:

	msr	cpsr, #0

is treated as:

	msr	cpsr_cf, #0

for backwards compatibility with earlier versions of the syntax for
this instruction.

Whilst this form of the instruction would still be bad with the v4 or
earlier architectures, the v5 architecture allows it.  Since by
default gas selects the v5 architecture, no error is produced.

Hence I would suggest that you amend the arm.exp file as shown below.
With this patch applied, I now get 0 failures.  I have not applied the
patch in case you feel that this is the wrong solution to the problem.

Cheers
	Nick


Index: gas/testsuite/gas/arm/arm.exp
===================================================================
RCS file: /cvs/src//src/gas/testsuite/gas/arm/arm.exp,v
retrieving revision 1.4
diff -p -r1.4 arm.exp
*** arm.exp	2001/01/01 13:43:06	1.4
--- arm.exp	2001/01/02 19:09:31
*************** if {[istarget *arm*-*-*] || [istarget "x
*** 7,13 ****
      gas_test "arm3.s" "" $stdoptlist "Arm 3 instructions"
  
      gas_test "arm6.s" "" $stdoptlist "Arm 6 instructions"
!     gas_test_error "msr-bad.s" "" "MSR with bad immediate operand"
  
      gas_test "arm7dm.s" "" $stdoptlist "Arm 7DM instructions"
  
--- 7,13 ----
      gas_test "arm3.s" "" $stdoptlist "Arm 3 instructions"
  
      gas_test "arm6.s" "" $stdoptlist "Arm 6 instructions"
!     gas_test_error "msr-bad.s" "-marmv3" "immediate value cannot be used to set this field"
  
      gas_test "arm7dm.s" "" $stdoptlist "Arm 7DM instructions"
  

   

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]