This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: x86-64 support for gas part I


On Mon, 18 Dec 2000, Jan Hubicka wrote:

> ! 		    if ((i.types[op] & Imm32)
> ! 			&& (i.op[op].imms->X_add_number & ~((offsetT) -2 << 31)) == 0)

You forgot to remove the `~'

> ! 	      else if (i.types[op] & Disp32)
> ! 		{
> ! 		  /* We know this operand is at most 32 bits, so convert to a
> ! 		     signed 32 bit number before trying to see whether it will
> ! 		     fit in an even smaller size.  */
> ! 		  disp = (((disp & 0xffffffff) ^ 0x80000000) - 0x80000000);
> ! 		}

Constants in range 0x80000000 to 0xffffffff here need fixing.

> --- 2730,2742 ----
>   	if (i.prefixes != 0 && !intel_syntax)
>   	  as_warn (_("skipping prefixes on this instruction"));
>   
> + 	if (i.prefix[REX_PREFIX])
> + 	  {
> + 	    FRAG_APPEND_1_CHAR (i.prefix[REX_PREFIX]);
> + 	    insn_size++;
> + 	    i.prefixes -= 1;
> + 	  }
> + 

This hunk had better go above the as_warn.

-- 
Linuxcare.  Support for the Revolution.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]