This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch for --gstabs and packing support in the generic assembler



:   * (This is just a personal thing): Postfixing boolean variables with
:     'p' really bugs me.  This is not LISP.  It is not even close to
:     LISP.  If you are programming in C, then make your variable names
:     C-like!  ie, I would have called the variable 'outputting_stabs_line_debug'
:     so that it could be tested in an if statement like this:
: 
:        if (outputting_stabs_line_debug_p)
:           ...


*^%$# cut-and-paste. I really meant:

:        if (outputting_stabs_line_debug)
:           ...
Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]