This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: more on ARM ELF flag merging
- To: philb at gnu dot org
- Subject: Re: more on ARM ELF flag merging
- From: Nick Clifton <nickc at redhat dot com>
- Date: Fri, 27 Oct 2000 11:43:51 -0700
- CC: binutils at sourceware dot cygnus dot com
Hi Phil,
: 2000-10-27 Philip Blundell <philb@gnu.org>
:
: * elf32-arm.h (elf32_arm_copy_private_bfd_data): Don't refuse
: attempts to mix PIC code with non-PIC, just mark the output as
: being position dependent.
: (elf32_arm_merge_private_bfd_data): Likewise. Print an error
: message for EF_SOFT_FLOAT mismatches. Display diagnostics for
: all mismatches, not just the first one.
Approved.
There are a couple of formatting nits which it would be nice too clean
up at the same time though:
: /* Complain about various flag mismatches. */
:
: if ((in_flags & EF_APCS_26) != (out_flags & EF_APCS_26))
There is no need for a blank line bwteen the comment and the code.
: /* Interworking mismatch is only a warning. */
Needs an extra space after the full stop.
Cheers
Nick