This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

rfa: [patch] testsuite/binutils-all/readelf.exp: Fix setup_xfail list handling, add cris-*-*


Possibly someone read through setup_xfail and misunderstood the Tcl "args"
magic.  Possibly I have misunderstood it too, but at least this works;
putting more than one argument in the list did not work before (at least
here, with Tcl 7.6).

The argument to setup_xfail is a number of items, not a list.  It is only
received as a list.  Calling setup_xfail multiple times instead is safe.
And now we don't have to check the number of items in the list before we
call setup_xfail...

Ok to commit?

2000-09-26  Hans-Peter Nilsson  <hp@axis.com>

	* binutils-all/readelf.exp (readelf_test): Correct setup_xfail
	call to loop through $xfails.
	(-wi test): Add cris-*-* to xfails.

Index: readelf.exp
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/readelf.exp,v
retrieving revision 1.3
diff -p -c -r1.3 readelf.exp
*** readelf.exp	2000/06/14 01:21:35	1.3
--- readelf.exp	2000/09/26 21:11:43
*************** proc readelf_test { options binary_file 
*** 166,173 ****
      send_log "exec $READELF $READELFFLAGS $options $binary_file > readelf.out\n"
      catch "exec $READELF $READELFFLAGS $options $binary_file > readelf.out" got
  
!     if { [llength $xfails] != 0 } then {
! 	setup_xfail $xfails
      }
      
      if ![string match "" $got] then {
--- 166,173 ----
      send_log "exec $READELF $READELFFLAGS $options $binary_file > readelf.out\n"
      catch "exec $READELF $READELFFLAGS $options $binary_file > readelf.out" got
  
!     for { set i 0 } { $i < [ llength $xfails ] } { incr i } {
! 	setup_xfail [ lindex $xfails $i ]
      }
      
      if ![string match "" $got] then {
*************** if [is_remote host] {
*** 252,255 ****
  # The xfail targets here do not default to DWARF2 format debug information
  # The symptom is that the output of 'readelf -wi' is empty.
  
! readelf_test -wi $tempfile readelf.wi {v850*-*-*}
--- 252,255 ----
  # The xfail targets here do not default to DWARF2 format debug information
  # The symptom is that the output of 'readelf -wi' is empty.
  
! readelf_test -wi $tempfile readelf.wi {v850*-*-* cris-*-*}

brgds, H-P

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]