This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] ld/pe-dll.c: ordinals and noname


Hi DJ,

: Any comments before I apply this?
: 
: 2000-09-14  DJ Delorie  <dj@redhat.com>
: 
: 	* pe-dll.c (fill_edata): rearrange the data so that ordinals and
: 	noname work properly.

Just one...

:   	  if (!pe_def_file->exports[s].flag_noname)
:   	    {
:   	      char *ename = pe_def_file->exports[s].name;
:   	      bfd_put_32 (abfd, ERVA (enamestr), (void *) enameptrs);
:   	      strcpy (enamestr, ename);
:   	      enamestr += strlen (enamestr) + 1;
: ! 	      bfd_put_16 (abfd, i, (void *) eordinals);
: ! 	      enameptrs++;
:   	      pe_def_file->exports[s].hint = hint++;
:   	    }
: --- 704,722 ----
:   	  if (!pe_def_file->exports[s].flag_noname)
:   	    {
:   	      char *ename = pe_def_file->exports[s].name;
:   	      bfd_put_32 (abfd, ERVA (enamestr), (void *) enameptrs);
: + 	      enameptrs++;
:   	      strcpy (enamestr, ename);
:   	      enamestr += strlen (enamestr) + 1;
: ! 	      bfd_put_16 (abfd, ord, (void *) eordinals);
: ! 	      eordinals++;
:   	      pe_def_file->exports[s].hint = hint++;
:   	    }

Why did you change the placement of the "enameptrs++" expression ?

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]