Re: Nasty elf orphan section bug.

[Alan Modra <alan at linuxcare dot com dot au>]

On Thu, 7 Sep 2000, Alan Modra wrote:

> ld/ChangeLog
> 	* emultempl/elf32.em (gld${EMULATION_NAME}_place_orphan): Fix
> 	broken list handling.  Create __start_SECNAME and __stop_SECNAME
> 	when no placeholder.  Add some comments.  Test both SEC_CODE and
> 	SEC_READONLY for hold_text to prevent .rodata orphan poisoning.

Drat.  Missed another problem when using weird linker scripts.

ld/ChangeLog
	Handle case where no output section statement created.

This can happen when an output section statement already exists for the
input orphan section.

Alan Modra
-- 
Linuxcare.  Support for the Revolution.

Index: emultempl/elf32.em
===================================================================
RCS file: /cvs/src/src/ld/emultempl/elf32.em,v
retrieving revision 1.34
diff -u -w -p -r1.34 elf32.em
--- elf32.em	2000/09/07 07:08:58	1.34
+++ elf32.em	2000/09/07 08:52:17
@@ -1203,9 +1203,11 @@ gld${EMULATION_NAME}_place_orphan (file,
 	}
       place->section = &snew->next;	/* Save the end of this list.  */
 
+      if (add.head != NULL)
+	{
       /* We try to put the output statements in some sort of
-	 reasonable order here, because they determine the final load
-	 addresses of the orphan sections.  */
+	     reasonable order here, because they determine the final
+	     load addresses of the orphan sections.  */
       if (place->stmt == NULL)
 	{
 	  /* Put the new statement list right at the head.  */
@@ -1219,13 +1221,14 @@ gld${EMULATION_NAME}_place_orphan (file,
 	  *place->stmt = add.head;
 	}
 
-      /* Fix the global list pointer if we happened to tack our new
-	 list at the tail.  */
+	  /* Fix the global list pointer if we happened to tack our
+	     new list at the tail.  */
       if (*old->tail == add.head)
 	old->tail = add.tail;
 
       /* Save the end of this list.  */
       place->stmt = add.tail;
+	}
     }
 
   return true;