Re: GAS for ARM: Reject ASR/LSR/ROR with immediate of 0

[Richard Earnshaw <rearnsha at arm dot com>]

nickc@redhat.com said:
> OK I have done that.  (Patch below).  Incidentally this whole topic
> started because on of customer had complained that GAS did not behave
> in the same way as ARM's assembler.  (Apparently ARM's assembelr
> rejects shifts of zero, rather than converting them into LSLs.)


So make it an as_warn, rather than an as_tsktsk.  Then the user can add -X 
to the assembly and will get an error.


nickc@redhat.com said:
! 	  if (num == 0)
! 	    {
! 	      as_tsktsk (_("Shift of 0 ignored."));
! >>>	      shift = shift_names;
! 	      assert (shift->properties->index == SHIFT_LSL);
! 	    }

On a point of style, I find assigning the "whole array" here confusing.  
It would be much clearer if this read

	shift = &shift_names[0];